On Tue, Sep 22, 2015 at 06:08:56PM -0500, J. German Rivera wrote:
> Add cmd_flags parameter to all dpbp APIs to comply
> with the dpbp 2.0 MC interface. Updated MC version
> major number. Pass irq args in struct instead of
> separate args.
>
> Signed-off-by: J. German Rivera <German.Rivera@xxxxxxxxxxxxx>
> ---
> drivers/staging/fsl-mc/bus/dpbp.c | 136 ++++++++++++++++++++----------
> drivers/staging/fsl-mc/include/dpbp-cmd.h | 2 +-
> drivers/staging/fsl-mc/include/dpbp.h | 91 +++++++++++++++-----
> 3 files changed, 162 insertions(+), 67 deletions(-)
>
> diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/staging/fsl-mc/bus/dpbp.c
> index d99ab6d..0004e65 100644
> --- a/drivers/staging/fsl-mc/bus/dpbp.c
> +++ b/drivers/staging/fsl-mc/bus/dpbp.c
> @@ -34,14 +34,19 @@
> #include "../include/dpbp.h"
> #include "../include/dpbp-cmd.h"
>
> -int dpbp_open(struct fsl_mc_io *mc_io, int dpbp_id, uint16_t *token)
> +int dpbp_open(struct fsl_mc_io *mc_io,
> + uint32_t cmd_flags,
> + int dpbp_id,
> + uint16_t *token)
> {
> struct mc_command cmd = { 0 };
> int err;
>
> /* prepare command */
> cmd.header = mc_encode_cmd_header(DPBP_CMDID_OPEN,
> - MC_CMD_PRI_LOW, 0);
> + cmd_flags,
> + 0);
Why are you reformatting all of these calls when you don't have to
create a new line? Seems wasteful to me, as is:
> +
That empty line, why?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
