On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify > that a buffer allocation failed. Since the error number is propagated, > the caller will get a -EPERM which is the wrong error condition. Just a little doubt. caller means the function which is calling this dgap_parsefile() or you meant the user? The function which is calling this dgap_parsefile() is just checking if it has received 0 or something else. Something else is error and it rerturns -EINVAL for all types of error (ofcourse that is also wrong). So the user will see -EINVAL for all types of error in dgap_parsefile(). regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
