On Sat, Aug 29, 2015 at 12:18:22AM -0500, Larry Finger wrote: > Even though you are just moving code, I think you should fix the > long line warnings from scripts/checkpatch, otherwise note that they > are not fixed here, but they will be fixed in a later patch. As for > the other warnings, they should be noted and fixed later. Please do *NOT* make unrelated changes when moving functions around. It makes it impossible to review the code. A malicious person could slip a bug into that and we would never see. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel