Re: [PATCH 06/18] staging: wilc1000: replace PRINT_D with netdev_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 20, 2015 at 03:51:13PM +0900, Chaehyun Lim wrote:
> This patch replaces PRINT_D with netdev_info in wilc_free_wiphy function.
> 
> Signed-off-by: Chaehyun Lim <chaehyun.lim@xxxxxxxxx>
> ---
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index fbe8643..216da0c 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -3691,7 +3691,7 @@ int WILC_WFI_DeInitHostInt(struct net_device *net)
>   */
>  void wilc_free_wiphy(struct net_device *net)
>  {
> -	PRINT_D(CFG80211_DBG, "Unregistering wiphy\n");
> +	netdev_info(net, "Unregistering wiphy\n");

these were only getting printed out if you had a specific debug flag
set.  But you just changed it to always print this message, which isn't
good.

As this really is just a debugging statement, can you make it
netdev_debug() instead?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux