Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 15, 2015 at 06:46:25AM -0700, Greg KH wrote:
> On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
> > 
> > 
> > On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
> > >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> > >>From: Glen Lee <glen.lee@xxxxxxxxx>
> > >>
> > >>g_num_total_switches is never used so just delete it.
> > >>
> > >>Signed-off-by: Glen Lee <glen.lee@xxxxxxxxx>
> > >>Signed-off-by: Tony Cho <tony.cho@xxxxxxxxx>
> > >>---
> > >you only deleted from the .h file but it still remains in
> > >coreconfigurator.c
> > >
> > >regards
> > >sudip
> > 
> > The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
> > but it's not accepted yet. So, you can find the variable still in c file.
> 
> I don't see that patch here in my queue :(
> 
> Please resend all of your outstanding patches, I think we are out of
> sync somehow.
This was the series of 7 patches and the first patch was
"remove PANDA_BOARD".
And the series is indeed not applied.

patch 7/7 was removing g_num_total_switches from the .c file, while
resending please modify and remove it from the .h file also.

And when your patch depends on some previous unapplied patch it will be
better if you can mention that in the comments.

regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux