Re: [PATCH 00/13] staging: wilc1000: remove WILC_CATCH and friends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 14, 2015 at 10:00:42PM +0300, Mike Rapoport wrote:
> Hi,
> 
> These patches replace usage of WILC_ERRORREPORT, WILC_ERRORCHECK,
> WILC_NULLCHECK and WILC_CATCH by plain code that either returns the error
> value or sets the error code and uses goto to jump to error handling code. 

As Sudip said, you can't have a patch that adds a build warning, and
then fix it up on later patches, each patch needs to be "stand alone"
and work just fine as-is, with no dependancy on later patches.

Please rework this series.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux