Re: [PATCH 01/13] staging: wilc1000: replace WILC_ERRORREPORT with return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 15, 2015 at 10:27:04AM +0300, Mike Rapoport wrote:
> On Tue, Sep 15, 2015 at 10:47:57AM +0530, Sudip Mukherjee wrote:
> > On Mon, Sep 14, 2015 at 10:00:43PM +0300, Mike Rapoport wrote:
> > > In cases where WILC_ERRORREPORT does not require cleanup actions, but
> > > causes immediate return from the function it can be replaced with return
> > > statement.
> > > 
> > > Signed-off-by: Mike Rapoport <mike.rapoport@xxxxxxxxx>
> > > ---
> > Have you build tested? It introduces lots of build warnings. Your patch
> > should never introduce build warnings.
> 
> Yes, I've build tested and I'm aware of build warnings. They are fixed
> later in the series, so that each patch will contain single logical
> change.
No, adding build warning is not allowed, even though you fix them in a
later patch in a series.

regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux