Re: [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 15, 2015 at 11:53:34AM +0900, Tony Cho wrote:
> This patch aims to remove the wilc_errorsupport.h which is unnecessary in the
> wilc driver. This patch replaces the error types defined by wilc driver with
> kernel generic error types and removes macros which handles the errors.

Patch 2/7 and 4/7 are introducing new checkpatch warnings which again
some has to fix in a separate patch. Better to fix it while you are
sending. And instead of printk it should be pr_err or much better if you
can use netev_err. Looks like it can be used in some of the functions.

regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux