Re: [PATCH 1/2] Staging: lustre: libcfs: Use pr_info and pr_warn macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Mon, 14 Sep 2015, Greg Kroah-Hartman wrote:

On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote:
Replace all occurrences of  printk(KERN_* by pr_info and pr_warn macros.

Build tested it.

Why put this here in the changelog area?  You always have to at least
build test your changes, so this is always implied.

Yes I'll take it off in this and future patches.


And can some of these be changed to be dev_* calls instead?

Since there is no network device pointer in this function, isn't pr_* preferred?

Thanks,

Shraddha


thanks,

greg k-h

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux