Re: [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2015년 09월 10일 03:17, Greg KH wrote:
On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote:
From: Glen Lee <glen.lee@xxxxxxxxx>

Call kmalloc directly. No need to wrap kmalloc.
Only one function, wilc_mq_send which use WILC_MALLOC, can be running in
interrupt context or process context. In this case, We call in_interrupt to
decide the flag, GFP_ATOMIC or GFP_KERNEL, for kmalloc properly. Additionally,
there is one kmalloc which flag is always GFP_ATOMIC. This also changed
together.
Others are not holding a spin lock or in interrupt context. So use GFP_KERNEL
flag for kmalloc.

Signed-off-by: Glen Lee <glen.lee@xxxxxxxxx>
Signed-off-by: Tony Cho <tony.cho@xxxxxxxxx>
---
  drivers/staging/wilc1000/host_interface.c         | 110 +++++++++++-----------
  drivers/staging/wilc1000/linux_wlan.c             |   2 +-
  drivers/staging/wilc1000/wilc_msgqueue.c          |  10 +-
  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |  38 ++++----
  4 files changed, 83 insertions(+), 77 deletions(-)
This no longer applies to my staging-testing branch, can you rebase it
and resend it and the other patches in this series?

thanks,

greg k-h

I will resend this patch with Kconfig with BROKEN removed.

Thanks,
Tony.


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux