Re: [PATCH 3/3] staging: fbtft: use pr_fmt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
Instead of defining DRVNAME and using it in all calls to pr_* family of
macros lets start using pr_fmt.

Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
---
  drivers/staging/fbtft/fbtft_device.c | 79 ++++++++++++++++--------------------
  1 file changed, 35 insertions(+), 44 deletions(-)

[...]

If a driver is working properly, nothing should show up in the kernel
log at all, otherwise it's just noise that everyone ignores.

This isn't a device driver, it's a module for adding "fbtft" devices
(spi/platform with pdata). When I created fbtft, the Raspberry Pi didn't
have Device Tree support, so I made this module as a way for the end user
to add devices without having to build a kernel.
I haven't seen any module like this in the kernel, so maybe it really doesn't
belong here at all?


Noralf.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux