Re: [PATCH 01/30] staging: wilc1000: rename WILC_WFI_CfgSetChannel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 09, 2015 at 12:55:38AM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_CfgSetChannel with
> wilc_cfg80211_set_monitor_channel to avoid CamelCase.

Like was said, this is now longer, how about something "simple" like
wilc_set_channel()?

Actually, as this is a static function, set_channel() would work, no
need to prefix static functions as it's obvious it is "wilc".

Same for all of the other patches in this series, can you please redo
them to be simpler?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux