Re: [PATCH 2/2] staging: dgnc: remove useless spinlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 05, 2015 at 01:12:02PM +0100, Salah Triki wrote:
> dgnc_poll_stop is a local variable in dgnc_driver.c, so it is useless to take dgnc_poll_lock before
> accessing to this variable.

No, not at all!  scope doesn't matter for locks, this patch is broken
and wrong.

How did you test it?

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux