On Fri, Sep 04, 2015 at 11:13:00AM -0700, David Matlack wrote: > On Fri, Sep 4, 2015 at 6:23 AM, Sudip Mukherjee > <sudipm.mukherjee@xxxxxxxxx> wrote: > > These variables were only assigned some values but they were never used. > > > > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> > > --- <snip> > > - status = slic_upr_request(adapter, SLIC_UPR_RLSR, > > - (u32) &pshmem->linkstatus, /* no 4GB wrap guaranteed */ > > - 0, 0, 0); > > + slic_upr_request(adapter, SLIC_UPR_RLSR, > > + (u32)&pshmem->linkstatus, /* no 4GB wrap guaranteed */ > > + 0, 0, 0); > > Is status safe to ignore? status can have two value either -ENOMEM or STATUS_PEMDING. Ideally we should have handled -ENOMEM. regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
