Re: [PATCH] staging/wlan-ng : Partial checkpatch cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 31, 2015 at 02:23:55AM -0700, Anish Bhatt wrote:
> * Replace memcmp(... ETH_ALEN) with ether_addr_equal_unaligned()
> * Replace memcpy(... ETH_ALEN) with ether_addr_copy()
> 
> Fixes :
> * CHECK : No space is necessary after a cast
> * CHECK : Please don't use multiple blank lines
> * CHECK : Alignment should match open parenthesis
> * CHECK : Unnecessary parentheses
> * CHECK : Comparison to NULL/!NULL

That's a lot of things to do in one patch.  Please only do one thing per
patch, this should be a patch series.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux