Re: [PATCH] staging: most: make helper functions static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 24, 2015 at 04:50:10PM +0200, Michał Bartoszkiewicz wrote:
> This fixes two "symbol was not declared. Should it be static?" sparse
> warnings.
> 
> Signed-off-by: Michał Bartoszkiewicz <mbartoszkiewicz@xxxxxxxxx>
> ---
>  drivers/staging/most/aim-sound/sound.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
> index 860302e..27449d2 100644
> --- a/drivers/staging/most/aim-sound/sound.c
> +++ b/drivers/staging/most/aim-sound/sound.c
> @@ -486,7 +486,7 @@ static struct snd_pcm_ops pcm_ops = {
>  };
>  
>  
> -int split_arg_list(char *buf, char **card_name, char **pcm_format)
> +static int split_arg_list(char *buf, char **card_name, char **pcm_format)
>  {
>  	*card_name = strsep(&buf, ".");
>  	if (!*card_name)
> @@ -497,7 +497,8 @@ int split_arg_list(char *buf, char **card_name, char **pcm_format)
>  	return 0;
>  }
>  
> -int audio_set_pcm_format(char *pcm_format, struct most_channel_config *cfg)
> +static int audio_set_pcm_format(char *pcm_format,
> +				struct most_channel_config *cfg)
>  {
>  	if (!strcmp(pcm_format, "1x8")) {
>  		if (cfg->subbuffer_size != 1)
> -- 
> 2.5.0
> 
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Someone already sent in this patch before you did :(
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux