On Wed, Sep 02, 2015 at 04:29:34PM -0700, Anish Bhatt wrote: > Same fbtft_par_dbg(DEBUG_SET_ADDR_WIN..) debug print is repeated in > every set_addr_win handler, repalce with a macro. Ick. > static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) > { > - fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, > - "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye); > + fbtft_par_dbg_addr_win(); This should just be deleted entirely, we have function tracing in the kernel if you want to use it, no need to write macros to duplicate the same thing. Please just remove these lines. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel