On 24/08/15 18:13, H Hartley Sweeten wrote:
Fix a couple minor checkpatch.pl issues.
Tidy up the ai (*do_cmdtest) and (*do_cmd) a bit.
v3: modify patch 10
According to the driver author, Bernd Porr, the hardware can produce
an anaog input value of 0x1000. The analog inputs are 12-bits (0x0fff)
and the extra bit indicates an overflow from the ADC.
v2: Address some issues pointed out by Ian Abbott and add a couple
more patches to remove some cruft.
1) Move the test in patch 6 to Step 3 as requested by Ian Abbott.
2) Add new patch 7 to simplify the TRIG_EXT trigger.
3) Merge old patches 7 and 8 into new patch 8. Cleanup the timing
validation.
4) Add new patches 10-13.
H Hartley Sweeten (13):
staging: comedi: usbduxfast: chanlist check is Step 5 of (*do_cmdtest)
staging: comedi: usbduxfast: only chanlist of 1,2,3, or 16 are supported
staging: comedi: usbduxfast: remove impossible 'if (!devpriv)' checks
staging: comedi: usbduxfast: use preferred kernel types
staging: comedi: usbduxfast: fix multi-line comment
staging: comedi: usbduxfast: TRIG_EXT only works for 1 or 16 channels
staging: comedi: usbduxfast: TRIG_EXT is only valid for cmd->start_src
staging: comedi: usbduxfast: tidy up the conversion timing validation
staging: comedi: usbduxfast: use a common exit path in ai (*do_cmd)
staging: comedi: usbduxfast: document strange ai maxdata
staging: comedi: usbduxfast: remove unnecessary semaphore down/up
staging: comedi: usbduxfast: absorb usbduxfast_attach_common()
staging: comedi: usbduxfast: remove unnecessary clearing of private data
drivers/staging/comedi/drivers/usbduxfast.c | 274 +++++++++++-----------------
1 file changed, 104 insertions(+), 170 deletions(-)
Looks good. Note that this driver will also require some le16_to_cpu()
conversions on the data read from the USB transfer buffer in
usbduxfast_ai_handle_urb() and usbduxfast_ai_insn_read().
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
