On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: > Oh! Sorry! I made the changes to correct the faults you figured out. > Is it okay now? Better. Also, submit it again with proper commit message and put "PATCH v2" in the subject. > > Signed-off-by: Aparna Karuthodi <kdasaparna@xxxxxxxxx> > --- > drivers/staging/fbtft/fb_pcd8544.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c > index cf87ce8..925511f 100644 > --- a/drivers/staging/fbtft/fb_pcd8544.c > +++ b/drivers/staging/fbtft/fb_pcd8544.c > @@ -34,8 +34,8 @@ > #define WIDTH 84 > #define HEIGHT 48 > #define TXBUFLEN (84*6) > -#define DEFAULT_GAMMA "40" > /* gamma is used to control contrast in this driver */ Aren't these two supposed to be on the same line? I think your patch is a bit messed up. Doublecheck this. > +#define DEFAULT_GAMMA "40" > > static unsigned tc; > module_param(tc, uint, 0); > -- > 1.7.9.5 > > _______________________________________________ > devel mailing list > devel@xxxxxxxxxxxxxxxxxxxxxx > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel