Hi Javier, On Friday 21 August 2015 02:14:05 Javier Martinez Canillas wrote: > On 08/20/2015 08:37 PM, Laurent Pinchart wrote: > > On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: > >> The struct media_entity does not have an .id field anymore since > >> now the entity ID is stored in the embedded struct media_gobj. > >> > >> This caused the omap4iss driver fail to build. Fix by using the > >> media_entity_id() macro to obtain the entity ID. > >> > >> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> > > > > This looks fine to me. The patch needs to be moved between Mauro's 1/8 and > > 2/8 patches to avoid breaking bisection with patch 3/8. I'd squash this > > patch and 2/4 into a single "media: Use media_entity_id() in drivers" > > patch. > > Yes, Hans and Mauro already mentioned it and I completely agree that > should be squashed with Mauro's patch to maintain git bisect-ability. I wouldn't squash patches 1/4 and 2/4 into Mauro's 3/8 patch as Hans proposed, but instead squashing them together into a single patch and move the result as 1.5/8 in Mauro's series. -- Regards, Laurent Pinchart _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
