On Wed, Aug 19, 2015 at 12:00 PM, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote: > On Tue, Aug 18, 2015 at 01:31:00PM -0300, Fabio Estevam wrote: >> On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee >> <sudipm.mukherjee@xxxxxxxxx> wrote: >> > According to the kernel coding style the NULL check should not be >> > written as [variable] == NULL or [variable] != NULL. >> >> It seems this not documented in Documentation/CodingStyle . > Yes, it is not in the CodingStyle file. But mostly it is the convention > that is followed. And in CodingStyle file if you see the "The rationale > for using gotos is:" section, you will see in the example function the > test is done like: if (!buffer). > Anyways, frankly speaking I know commit message is bad but I could not > think of anything else other than the one I wrote. Any ideas please... Maybe something like: Although not made explicit in Documentation/CodingStyle, there seems to be a preference for writing NULL tests as 'if (!var)' rather than if (var == NULL). The coding style does explicitly prefer brevity, so convert all NULL checks to follow this shorter approach. Frans _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
