Hi, Here is an update of the patches fixing all the checkpatch warnings and errors for the file drivers/staging/rtl8192u/r8192U_core.c, thanks to Sudop Mukherjee's remarks and advices. As a reminder, here is the checkpatch.pl tailed output before patches: total: 334 errors, 402 warnings, 4909 lines checked And after patches: total: 0 errors, 0 warnings, 5379 lines checked Please let me know if there is anything else I can do to improve these patches! Thanks, Raphaël Raphaël Beamonte (19): staging: rtl8192u: r8192U_core: fix switch and case indent code style error staging: rtl8192u: r8192U_core: fix space before close parenthesis code style error staging: rtl8192u: r8192U_core: fix code indent using spaces code style error staging: rtl8192u: r8192U_core: fix else following close brace code style error staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing code style error staging: rtl8192u: r8192U_core: whitespace neatening to fix consistent spacing code style errors staging: rtl8192u: r8192U_core: clean C99 // comments staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.h staging: rtl8192u: r8192U_core: remove return statement of void function staging: rtl8192u: r8192U_core: fix unecessary braces code style issue staging: rtl8192u: r8192U_core: remove forward declarations in .c file staging: rtl8192u: r8192U_core: fix unnecessary check before kfree code style issue staging: rtl8192u: r8192U_core: fix unnecessary parentheses code style issue staging: rtl8192u: r8192U_core: fix unnecessary else after return code style issue staging: rtl8192u: r8192U_core: fix unnecessary whitespace code style issue staging: rtl8192u: r8192U_core: fix missing blank line after declarations code style issue staging: rtl8192u: r8192U_core: fix quoted string split across lines code style issue staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue staging: rtl8192u: r8192U_core: fix line over 80 characters code style issue drivers/staging/rtl8192u/r8192U.h | 4 +- drivers/staging/rtl8192u/r8192U_core.c | 2262 +++++++++++++++++++------------- 2 files changed, 1368 insertions(+), 898 deletions(-) -- 2.1.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel