Re: [PATCH] staging: dgnc: take mutex when storing value in dgnc_poll_tick

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 17, 2015 at 11:11:05PM +0100, Salah Triki wrote:
> On Mon, Aug 17, 2015 at 09:26:15PM +0300, Dan Carpenter wrote:
> > On Mon, Aug 17, 2015 at 04:19:12PM +0100, Salah Triki wrote:
> > > Since dgnc_poll_trick is a global variable.
> > > 
> > > Signed-off-by: Salah Triki <salah.triki@xxxxxxx>
> > 
> > Does this changelog even mean?
> > 
> > Why is Mark not on the CC list?  Use scripts/get_maintainer.pl.
> > 
> > I think there probably is a bug here, but access is still racy.  I think
> > we should use dgnc_poll_lock to serialize it.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Sorry for the changelog, I will change it in the next version.
> 
> Mark Hounschell's email (markh@xxxxxxxxxx) is on the CC.

That's really weird.  The email list removes him from the CC.  Salah
added him and then the mailing list removed him.  I added him back and
the mailing list removed him.

This has happened several times before and I have always just assumed
that people didn't add Mark for whatever reason...  Very strange.

> 
> dgnc_poll_lock is a static variable, may be we should use dgnc_global_lock instead.

Nope.  Make it not static.  The dgnc_poll_lock and the dgnc_global_lock
are different things.

regards,
dan carpenter

> 
> regards,
> salah triki
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux