2015-08-17 13:47 GMT-04:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
>> - printk("[Sendconfigpkt]Get Timed out\n");
>> + pr_debug("[Sendconfigpkt]Get Timed out\n");
>
>
> Possibly pr_err()?
Yep. My mistake. I'll do the same for Set Timed Out also!
>> - printk("DBG [%s: %d]", __func__, __LINE__); \
>> - printk(__VA_ARGS__); \
>> + pr_debug("DBG [%s: %d]", __func__, __LINE__); \
>> + pr_debug(__VA_ARGS__); \
>
> This is a behavior change, I think. pr_debug() needs to be turned on?
Yes... I didn't pay attention to that! pr_debug needs -DDEBUG in the makefile.
Should I use pr_info here? Or just acknowledge the behavior change for
the moment,
as the next aim is probably, as you said, to remove all the local
debug code? (it is
actually part of the TODO of this driver... So I could just work on that next.)
I'll include your other log level advices and send a new version.
Thanks for your
reviewing time!
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
