On Sun, Aug 16, 2015 at 01:30:12AM -0400, Raphaël Beamonte wrote:
> #define MALLOC_WILC_BUFFER(name, size) \
> - exported_ ## name = kmalloc(size, GFP_KERNEL); \
> - if (!exported_ ## name) { \
> - printk("fail to alloc: %s memory\n", exported_ ## name); \
> - return -ENOBUFS; \
> - }
> + do { \
> + exported_ ## name = kmalloc(size, GFP_KERNEL); \
> + if (!exported_ ## name) { \
> + printk("fail to alloc: %s memory\n", exported_ ## name); \
> + return -ENOBUFS; \
> + }
> + } while (0)
Pull it in one indent level... But actually this macro has a return in
the middle of it, so it just introduces bugs all over the place like
eating cookies in bed. We should just delete it instead.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
