Re: [PATCH 0/5] staging: comedi: comedi_fops: remove BUG_ON() checkes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/08/15 21:13, H Hartley Sweeten wrote:
Drivers should not crash the kernel.

H Hartley Sweeten (5):
   staging: comedi: comedi_fops: absorb comedi_free_board_minor()
   staging: comedi: comedi_fops: remove BUG_ON() in comedi_dev_get_from_board_minor()
   staging: comedi: comedi_fops: remove BUG_ON() in comedi_free_subdevice_minor()
   staging: comedi: comedi_fops: remove BUG_ON() in comedi_cleanup()
   staging: comedi: comedi_fops: remove remaining BUG_ON() checks

  drivers/staging/comedi/comedi_fops.c | 29 +++++++----------------------
  1 file changed, 7 insertions(+), 22 deletions(-)


I agree they're not really needed and can be removed (as you have done) or replaced.

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux