On Friday, August 07, 2015 10:34 PM, Sudip Mukherjee wrote: > On Fri, Aug 07, 2015 at 11:45:03AM -0700, H Hartley Sweeten wrote: >> Define the bits in this register. Remove the old defines in hwdrv_apci1564.c. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> Cc: Ian Abbott <abbotti@xxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> --- > The #defines that are introduced in this patch and the next 2 patches > are not being used anywhere, even after the whole series is applied. > Then why having them now? someone else will can a patch to clean the > unused defines. Correct, they are not being used (yet). The addi_apci_1564 driver still needs a bit of cleanup in order to merge in the code from hwdrv_apci1564 and remove the ugly include of that file. Right now I'm not sure if these defines are going to be needed or not. To keep my head straight while doing the cleanup it's easier if the registers are fully defined. Also, the register definitions for the ADDI-DATA boards are not easily obtained. I got them direct from ADDI-DATA but the information is a but messy since it's, mostly, in German. Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
