On 05/08/15 18:44, H Hartley Sweeten wrote:
Here's the big cleanup series for the Comedi me4000 driver.
This fixes all the checkpatch issues and removes a bunch of cruft
from the driver.
v2: Address some issues pointed out by Ian Abbott, the comedi core
does not validate the 'aref' so the driver needs to handle it.
H Hartley Sweeten (46):
staging: comedi: me4000: remove 'dio_nchan' boardinfo
staging: comedi: me4000: all board types have analog inputs
staging: comedi: me4000: only set SDF_DIFF when supported
staging: comedi: me4000: remove 'chan' check in me4000_ai_insn_read()
staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()
staging: comedi: me4000: remove 'board' from me4000_ai_check_chanlist()
staging: comedi: me4000: make boardinfo flags bit-fields
staging: comedi: me4000: refactor 'ai_diff_nchan' boardinfo
staging: comedi: me4000: refactor 'ao_nchan' boardinfo
staging: comedi: me4000: refactor 'ao_fifo' boardinfo
staging: comedi: me4000: refactor 'ai_sh_nchan' boardinfo
staging: comedi: me4000: rename local variables used for 'dev->private'
staging: comedi: me4000: remove unnecessary ME4000_AI_LIST_INPUT_SINGLE_ENDED
staging: comedi: me4000: simplify analog input range programming
staging: comedi: me4000: fix ai_write_chanlist()
staging: comedi: me4000: tidy up ME4000_AI_CHANNEL_LIST_REG bit defines
staging: comedi: me4000: use comedi_timeout() to wait for ai (*insn_read)
staging: comedi: me4000: fix me4000_ai_insn_read()
staging: comedi: me4000: use correct types for extracted chanspec values
staging: comedi: me4000: use comedi_range_is_bipolar() in ai (*insn_read)
staging: comedi: me4000: tidy up ME4000_AI_STATUS_REG bit defines
staging: comedi: me4000: tidy up ME4000_AI_CTRL_REG bit defines
staging: comedi: me4000: tidy up ME4000_IRQ_STATUS_REG bit defines
staging: comedi: me4000: tidy up ME4000_AO_STATUS_REG bit defines
staging: comedi: me4000: tidy up ME4000_AO_CTRL_REG bit defines
staging: comedi: me4000: tidy up ME4000_DIO_CTRL_REG bit defines
staging: comedi: me4000: return void from ai_round_cmd_args()
staging: comedi: me4000: move ai command timing values into private data
staging: comedi: me4000: simplify ai_prepare()
staging: comedi: me4000: absorb ai_prepare()
staging: comedi: me4000: absorb ai_write_timer()
staging: comedi: me4000: return void from me4000_ai_write_chanlist()
staging: comedi: me4000: fix me4000_ai_cancel()
staging: comedi: me4000: remove unnecessary ai control register reset
staging: comedi: me4000: remove unnecessary me4000_ai_cancel()
staging: comedi: me4000: clear the ME4000_AI_CTRL_REG in me4000_reset()
staging: comedi: me4000: introduce me4000_ai_reset()
staging: comedi: me4000: only enable PLX interrupt if we have and irq
staging: comedi: me4000: fix me4000_detach()
staging: comedi: me4000: tidy up analog output subdevice init
staging: comedi: me4000: comedi_handle_events() will stop conversions
staging: comedi: me4000: introduce me4000_ai_get_sample()
staging: comedi: me4000: usleep_range is preferred over udelay
staging: comedi: me4000: cleanup multi-line comments
staging: comedi: me4000: updata driver status in comedi comment
staging: comedi: me4000: update MODULE_DESCRIPTION
drivers/staging/comedi/drivers/me4000.c | 1000 +++++++++++++------------------
1 file changed, 422 insertions(+), 578 deletions(-)
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
