Re: [PATCH] zram: Replace pr_* with dev_*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On (08/06/15 01:24), Dan Carpenter wrote:
> On Tue, Aug 04, 2015 at 07:19:01PM +0100, Salah Triki wrote:
> > @@ -508,14 +509,15 @@ static struct zram_meta *zram_meta_alloc(int device_id, u64 disksize)
> >  	num_pages = disksize >> PAGE_SHIFT;
> >  	meta->table = vzalloc(num_pages * sizeof(*meta->table));
> >  	if (!meta->table) {
> > -		pr_err("Error allocating zram address table\n");
> > +		dev_err("Error allocating zram address table for device %d",
> > +			device_id);
> 
> Does this even compile?

Hi,

We've seen this patch; and I NACK-ed it. Salah, please don't
try to push it some other way.

	-ss
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux