Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote:
> On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote:
> > On Mon, Aug 03, 2015 at 11:18:31AM +0000, Shah, Yash (Y.) wrote:
> > > From: Yash Shah <yshah1@xxxxxxxxxxx>
> > > 
> > > Fixed code indentation warning as detected by checkpatch.pl.
> > > 
> > > Signed-off-by: Yash Shah <yshah1@xxxxxxxxxxx>
> > 
> > Defines aren't allowed in .c files anyway.
> 
> The kernel source tree disagrees with you
> 
> $ git grep "^\s*#\s*define\b" -- "*.c" | wc -l
> 175830

Duh.  Sorry.  I meant ifdefs.  I'm sure you can find lots of examples
of those too, but this code would be cleaner without the ifdefs.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux