Re: [PATCH 06/13] staging/lustre: Drop SEEK_* definition checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 30, 2015 at 06:27:57PM -0400, green@xxxxxxxxxxxxxx wrote:
> From: Oleg Drokin <green@xxxxxxxxxxxxxx>
> 
> SEEK_DATA and SEEK_HOLE are always defined in the kernel,
> drop the definition checks
> 
> Signed-off-by: Oleg Drokin <oleg.drokin@xxxxxxxxx>
> ---
>  .../lustre/lustre/include/linux/lustre_compat25.h  | 38 ----------------------
>  1 file changed, 38 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h b/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
> index d0e8f3c..7d90999 100644
> --- a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
> +++ b/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
> @@ -69,37 +69,6 @@
>  # define inode_dio_read(i)		atomic_inc(&(i)->i_dio_count)
>  /* inode_dio_done(i) use as-is for read unlock */
>  
> -static inline int
> -ll_quota_on(struct super_block *sb, int off, int ver, char *name, int remount)
> -{
> -	int rc;
> -
> -	if (sb->s_qcop->quota_on) {
> -		struct path path;
> -
> -		rc = kern_path(name, LOOKUP_FOLLOW, &path);
> -		if (!rc)
> -			return rc;
> -		rc = sb->s_qcop->quota_on(sb, off, ver
> -					    , &path
> -					   );
> -		path_put(&path);
> -		return rc;
> -	} else
> -		return -ENOSYS;
> -}
> -
> -static inline int ll_quota_off(struct super_block *sb, int off, int remount)
> -{
> -	if (sb->s_qcop->quota_off) {
> -		return sb->s_qcop->quota_off(sb, off
> -					    );
> -	} else
> -		return -ENOSYS;
> -}
> -
> -
> -

This code removal doesn't match up with the changelog text, so I can't
take this :(

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux