Hi, Greg I'm sorry that I did not say whether GFP_ATOMIC should be used or not. This is my review on it. If it's not correct, please give me any comment or direction. First patch has 4 sites of kmalloc change in coreconfigurator.c First one, it is used for gps8ConfigPacket at CoreconfiguratorInit and CoreConfiguratorDeInit. I think it should be removed next time because I cannot find anywhere to use it. Then, it is okay to change flag as GFP_KERNEL. Other three changes are used to handle host interface message within a kernel thread. The manipulation of host interface message is not called on IRQ context and I could not find any spin lock inside function. If this patches are accepted, I will try to continue to change WILC_MALLOC macro as kmalloc. I always appreciate your comment and advice. Thanks Chaehyun Lim Chaehyun Lim (3): staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC staging: wilc1000: coreconfigurator.c: add kmalloc error check staging: wilc1000: coreconfigurator.c: fix kmalloc error check drivers/staging/wilc1000/coreconfigurator.c | 38 +++++++++++++++++------------ 1 file changed, 23 insertions(+), 15 deletions(-) -- 1.9.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
