RE: [PATCH V4 6/7] hvsock: introduce Hyper-V VM Sockets feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: David Miller
> Sent: Thursday, July 30, 2015 6:28
> >From: Dexuan Cui
> >Date: Tue, 28 Jul 2015 05:35:23 -0700
> >
> > +/* hvsock_release() can be invoked in 2 paths:
> > + * 1. on process termination:
> > + *	hvsock_sk_destruct+0x1a/0x20
> > + *	__sk_free+0x1d/0x130
> > + *	sk_free+0x19/0x20
> > + *	hvsock_release+0x138/0x160
> > + *	sock_release+0x1f/0x90
> > + *	sock_close+0x12/0x20
> > + *	__fput+0xdf/0x1f0
> > + *	____fput+0xe/0x10
> > + *	task_work_run+0xd4/0xf0
> > + *	do_exit+0x334/0xb90
> > + *	? __do_page_fault+0x1e1/0x490
> > + *	? lockdep_sys_exit_thunk+0x35/0x67
> > + *	do_group_exit+0x54/0xe0
> > + *	SyS_exit_group+0x14/0x20
> > + *	system_call_fastpath+0x16/0x1b
> > + *
> > + *  2. when accept() returns -ENITR:
> > + *	hvsock_release+0x151/0x160
> > + *	sock_release+0x1f/0x90
> > + *	sock_close+0x12/0x20
> > + *	__fput+0xdf/0x1f0
> > + *	____fput+0xe/0x10
> > + *	task_work_run+0xb7/0xf0
> > + *	get_signal+0x750/0x770
> > + *	do_signal+0x28/0xbb0
> > + *	? put_unused_fd+0x52/0x60
> > + *	? SYSC_accept4+0x1ca/0x220
> > + *	do_notify_resume+0x4f/0x90
> > + *	int_signal+0x12/0x17
> > + */
> 
> It is a bit much to put full stack backtraces into a comment like this.

Thanks for reviewing the patch, David!
I'll remove these lines and add a proper comment here.

Thanks,
-- Dexuan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux