On Wednesday, July 29, 2015 2:37 PM, Dan Carpenter wrote:
> We checked that "it->options[3]" was non-zero on the line before so
> there is no need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
v
> diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c
> index d7cf4b1..056bca9 100644
> --- a/drivers/staging/comedi/drivers/das16.c
> +++ b/drivers/staging/comedi/drivers/das16.c
> @@ -1032,8 +1032,7 @@ static int das16_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>
> /* check that clock setting is valid */
> if (it->options[3]) {
> - if (it->options[3] != 0 &&
> - it->options[3] != 1 && it->options[3] != 10) {
> + if (it->options[3] != 1 && it->options[3] != 10) {
> dev_err(dev->class_dev,
> "Invalid option. Master clock must be set to 1 or 10 (MHz)\n");
> return -EINVAL;
Thanks,
Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
