The original code is fine... I probably would write it the way you suggest, but I can also see why people would write it the other way. This isn't an official CodingStyle rule so I feel like the author gets to choose. Part of the reason for CodingStyle is so that we don't run into madness of changing every single thing all the time. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel