re: Staging: most: add MOST driver's hdm-usb module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Christian Gromm,

The patch a4198cdf0c34: "Staging: most: add MOST driver's hdm-usb
module" from Jul 24, 2015, leads to the following static checker
warning:

	drivers/staging/most/hdm-usb/hdm_usb.c:147 trigger_resync_vr()
	error: doing dma on the stack (&data)

drivers/staging/most/hdm-usb/hdm_usb.c
   143  static inline void trigger_resync_vr(struct usb_device *dev)
   144  {
   145          int data = 0;
   146  
   147          if (0 > usb_control_msg(dev,
                    ^^^^^^^^^^^^^^^^^^^^
The Yoda code here is totally weirding me out.

   148                                  usb_sndctrlpipe(dev, 0),
   149                                  0,
   150                                  USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_ENDPOINT,
   151                                  0,
   152                                  0,
   153                                  &data,
                                         ^^^^
Some arches don't allow DMA to the stack, only to kmalloc()ed memory.

   154                                  0,
   155                                  5 * HZ))
   156                  pr_info("Vendor request \"stall\" failed\n");
   157  }

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux