Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The subject isn't right.  You aren't patch checkpatch.pl itself you're
patching android.

The version doesn't go in the subject.

The subject is too vague.

On Tue, Jul 28, 2015 at 03:28:33PM +0530, Jignesh R Patel wrote:
> From: Jignesh R Patel <jigneshpatel0103@xxxxxxxxx>

Not needed.

> 
> This patch fix coding style problem of more then
> 80 character in one line. This patch does not change any
> logic.
> 
> Signed-off-by: Jignesh R Patel <jigneshpatel0103@xxxxxxxxx>
> ---
>  drivers/staging/android/ion/ion_cma_heap.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index 86b91fd..4a9a7bd 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!info->table)
>  		goto free_mem;
>  
> -	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len))
> +	if (dma_get_sgtable(dev, info->table, info->cpu_addr,
> +						info->handle, len))

This isn't the right way to do it.  I suppose the right thing is:

	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle,
			    len))

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux