Re: [PATCH 6/7] staging: unisys: visornic - consolidate+simplify xmit watermark checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 24, 2015 at 12:00:24PM -0400, Benjamin Romer wrote:
> -		max(2, devdata->max_outstanding_net_xmits - 1);
> +		max(2UL, (devdata->max_outstanding_net_xmits - 1));

It's weird here to treat ->max_outstanding_net_xmits equals zero as a
ULONG_MAX but it looks deliberate...  Perhaps add a comment?

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux