On Thu, Jul 23, 2015 at 03:05:16AM +0000, Dexuan Cui wrote: > The kind of usage is not rare in the kernel code: Yeah. But it's used 5% of the time. If it's under 15% then there is a risk that we'll write a checkpatch rule to enforce the standard way... There are some places where != 0 is idiomatic, like when you are talking about the number zero. strcmp() and friends should always be != 0 or == 0. In this specific case, writing it as "if (ret != 0)" caused the bug. If we had written it as "if (ret) return ret;" then there are no zeroes so wouldn't have been any temptation to return the zero instead of the ret. > Hi Dan, I read this as a humor. :-) :) regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
