Re: [PATCH 15/15] staging: unisys: make module unremoveable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 21, 2015 at 09:55:49AM -0400, Benjamin Romer wrote:
> From: Neil Horman <nhorman@xxxxxxxxxx>
> 
> As per the last commit, once a netdevice is registered, theres nothing to
> unregister it, even if the module is removed. That's obviously a memory
> leak and an easy oops vector.
> 
> Fixing it isn't hard, but it requires that some additional infrastructure
> be put in place to handle device removal and shutdown that isn't in the
> driver yet.  Given our short runway of time here I suggest that instead,
> we simply remove the module cleanup routine.

What "short runway of time"?  Please fix this properly, there is no rush
or deadlines for kernel development, sorry.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux