On Tue, Jul 21, 2015 at 11:43:52AM +0530, Sudip Mukherjee wrote: > On Tue, Jul 21, 2015 at 11:39:49AM +0530, Sudip Mukherjee wrote: > > On Mon, Jul 20, 2015 at 02:15:35PM +0300, Cihangir Akturk wrote: > > > obd_device_list_sops and obd_device_list_fops are not > > > referenced outside of linux-module.c, so make them static. > > And they are not modified also, so const ? > You have done that in 2/2 ... > sorry for the noise. I was going to say the same thing when I reviewed the patch. Really it should have been done as one patch. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
