On Tue, Jul 21, 2015 at 08:28:06AM +0200, Maciek Borzecki wrote:
> On Tue, Jul 21, 2015 at 8:19 AM, Sudip Mukherjee
> <sudipm.mukherjee@xxxxxxxxx> wrote:
> > On Mon, Jul 20, 2015 at 06:10:04PM +0200, Maciek Borzecki wrote:
> >> Remove unnecessary braces where appropriate. Fix non-tab
> >> indentation.
> >>
> >> This removes the following checkpatch warnings:
> >> WARNING: braces {} are not necessary for single statement blocks
> >>
> >> ERROR: code indent should use tabs where possible
> > That becomes 2 different types of change.
> > This change was in your v1 also, I didn't notice :(
> > Please do only one type of change in one patch,
>
> Could you look at the second patch[1] for any potential issues as well?
> I'll then resubmit the whole set to avoid going back and forth.
>
> [1] http://article.gmane.org/gmane.linux.drivers.driver-project.devel/72155
There was a minor alignment issue, when you changed it to pr_debug from
dprintk. run your patch through --strict option of checkpatch. other
than that looked ok.
regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
