> -----Original Message-----
> From: Vitaly Kuznetsov
> Sent: Friday, July 17, 2015 23:04
> To: Dexuan Cui
> Dexuan Cui writes:
>
> >> From: David Miller
> >> Sent: Thursday, July 16, 2015 12:19
> >>
> >> From: Dexuan Cui
> >> Date: Tue, 14 Jul 2015 03:00:48 -0700
> >>
> >> > + pr_debug("hvsock_sk_destruct: called\n");
> >>
> >> Debug logging just to state that a function is called is not appropriate,
> >> we have very sophisticated tracing facilities in the kernel that can do
> >> that transparently, and more.
> >>
> >> Please remove this.
> > OK.
> >
> >> > + if (hvsk->channel) {
> >> > + pr_debug("hvsock_sk_destruct: calling vmbus_close()\n");
> >>
> >> Likewise, these kinds of debug logs are totally inappropriate.
> > OK, I'll remove all the pr_debug() in the patch.
> >
>
> I'd suggest we rather use something like net_dbg_ratelimited()
> intead. The driver is new so issues are expected. Some debugging may
> be useful)
>
> Vitaly
The net_*ratelimited() functions may lose message if the messages are
printed very frequently, like in hvsock_sendmsg()/hvsock_recvmsg().
I used pr_debug() because I saw it's widely used in net/ipv4/.
Usually CONFIG_DYNAMIC_DEBUG=y, so pr_debug() means
dynamic_pr_debug(), which won't output anything by default.
Sorry, I'm not sure about the "sophisticated tracing facilities in the
kernel that can do that transparently, and more" mentioned by David.
Anyway, I don't mind simply removing the pr_debug() usages.
I will send out V3 later today.
Thanks,
-- Dexuan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
