Re: [PATCH] Staging: drivers: dgnc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 17, 2015 at 12:20:42AM +0000, Craig Inches wrote:
> Hi Joe,
> 
> On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote:
> > On Thu, 2015-07-16 at 23:11 +0000, Craig Inches wrote:
> > > Fixed up some checkpatch.pl style issues.
> > > Line greater than 80 Chars in multiple locations.
> > 
> > I think most all of these are not improvements.
> 	Ok, can you be a little more specific? I did see some that where
> 	not worth modifying due to only being 1 or 2 chars over, and
> 	breaking the line seemed pointless.
> 
> > Please use --strict when verifying your patches.
> 	Not sure where the --strict should be set? I cant see the option
> 	in  the checklist.pl script 
	found it missed the line after --subjective with -h  
	I shall take another crack at a patch, I see some issues
	introduced which wern't reported with just a normal
	checkpatch.pl run.

> > Please fix the time on your systemp.
> 	Thanks for pointing that out, my mail servers time was out.
> 
> Thanks for your feedback.
> Craig

-- 
Craig Inches

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux