Re: [PATCH v2 05/23] staging: rtl8192e: Remove unused fields from rtllib_stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 14, 2015 at 10:04:08PM +0200, Mateusz Kulikowski wrote:
> None of them are used in the driver.
> 
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@xxxxxxxxx>
> ---
>  drivers/staging/rtl8192e/rtllib.h | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 8ba92ed..dc0653a 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -691,27 +691,8 @@ struct rtllib_frag_entry {
>  };
>  
>  struct rtllib_stats {
> -	unsigned int tx_unicast_frames;
> -	unsigned int tx_multicast_frames;
> -	unsigned int tx_fragments;
> -	unsigned int tx_unicast_octets;
> -	unsigned int tx_multicast_octets;
> -	unsigned int tx_deferred_transmissions;
> -	unsigned int tx_single_retry_frames;
> -	unsigned int tx_multiple_retry_frames;
> -	unsigned int tx_retry_limit_exceeded;
>  	unsigned int tx_discards;
> -	unsigned int rx_unicast_frames;
> -	unsigned int rx_multicast_frames;
> -	unsigned int rx_fragments;
> -	unsigned int rx_unicast_octets;
> -	unsigned int rx_multicast_octets;
> -	unsigned int rx_fcs_errors;
> -	unsigned int rx_discards_no_buffer;
> -	unsigned int tx_discards_wrong_sa;
>  	unsigned int rx_discards_undecryptable;
Dan had commented before that tx_discards and rx_discards_undecryptable
are also not used. Their only uses are:
 ieee->ieee_stats.rx_discards_undecryptable++ and
 ieee->ieee_stats.tx_discards++

regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux