Re: [patch] checkpatch: Fixes: tag lines are allowed to be long

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2015-07-14 at 14:07 +0300, Dan Carpenter wrote:
> A lot of the Fixes: tags go over the 75 character limit and that's ok.
> 
> Fixes: 2a076f40d8c9 ('checkpatch, SubmittingPatches: suggest line wrapping commit messages at 75 columns')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> The other common cause of false positives it Oops output but I don't
> have an idea how to filter for that.
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 90e1edc..537973b 100755[0-9a-f
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2310,7 +2310,7 @@ sub process {
>  
>  # Check for line lengths > 75 in commit log, warn once
>  		if ($in_commit_log && !$commit_log_long_line &&
> -		    length($line) > 75) {
> +		    length($line) > 75 && !($line =~ /^Fixes:/)) {
>  			WARN("COMMIT_LOG_LONG_LINE",
>  			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
>  			$commit_log_long_line = 1;

Maybe some combination of:

^\s*> 
^.*\[\s*timestamp\s*\]
^\s*\[\<0-9a-f\>\]
oops:
BUG: Unable to 
Unable to

Followed by any blank line to reset

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux