Hi Johnny, On Fri, Jul 10, 2015 at 6:11 PM, Johnny Kim <johnny.kim@xxxxxxxxx> wrote: > > On 2015년 07월 10일 15:25, Julian Calaby wrote: >> >> Hi Johnny, >> >> On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim <johnny.kim@xxxxxxxxx> wrote: >>> >>> Last argument of wilc_wlan_cfg_get function is actually structure's >>> address. >>> This should be changed to be compatible with 64bit machine. >>> Because wilc_wlan_cfg_get function is mapped by function pointer later, >>> wilc_wlan_oup_t.wlan_cfg_get should be changed together. >>> >>> tstrWILC_WFIDrv structure is defined after wilc_wlan_oup_t.wlan_cfg_get >>> is defined. So, this patch changes the argument to void type pointer. >> >> Why not add a patch moving the structure definition before >> wilc_wlan_oup_t.wlan_cfg_get is defined? > > Current patch focus on accessing 64bit address rightly. > The define order you and I mentioned should be repaired with another subject > because of complexity among files. I'm not saying it should be part of this patch, I'm saying that it should be a patch in this series. Some of the changes you're making look like you're fixing one bug only to replace it with another different one. But back to the whole issue of order: tstrWILC_WFIDrv is defined in host_interface.h wlan_cfg_get is defined in wilc_wlan_if.h A patch ensuring that host_interface.h is included before wilc_wlan_if.h in all files should be pretty easy to produce, assuming that host_interface.h doesn't use anything in wilc_wlan_if.h. If you include this patch, you can avoid patches later to change the void pointers to typed pointers. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
