Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2015-07-07 at 15:32 -0400, Valdis.Kletnieks@xxxxxx wrote:
> All:  Is it time to kill that checkpatch test, or hide it behind a non-default
> flag, to prevent code churn?

<shrug> I'm not an 80 column zealot.

This is for staging isn't it?
Code churn there is expected and somewhat desired.

A lot of time, code churn can be useful when it
reduces the indentation depth.

For instance, this code could use continue more.

The longest line in this file is 158 chars, that's
probably excessive,  awk shows 35 lines > 80 chars.

staging rtl files have a couple hundred lines > 132
and thousands of lines > 80.


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux