On Wed, Jul 01, 2015 at 12:42:24PM +0530, Sudip Mukherjee wrote: > On Tue, Jun 30, 2015 at 11:54:59PM +0200, Michel von Czettritz wrote: > > The return value of FillH2CCmd in rtl8723a_set_rssi_cmd and > > rtl8723a_set_raid_cmd is never checked. Both functions always return > > _SUCCESS. > > > > Both functions now return the return value of FillH2CCmd. > If they are never checked then why do we need to return some value? > why not make them void? They probably *should* be checked eventually? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel