Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 29, 2015 at 06:11:22PM -0300, Fabio Estevam wrote:
> On Mon, Jun 29, 2015 at 5:55 PM, Nik Nyby <nikolas@xxxxxxx> wrote:
> > This fixes a typo: base_flag_bumber to base_flag_number
> >
> > Signed-off-by: Nik Nyby <nikolas@xxxxxxx>
> > ---
> >  drivers/hv/hyperv_vmbus.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
> > index cddc0c9..6383707 100644
> > --- a/drivers/hv/hyperv_vmbus.h
> > +++ b/drivers/hv/hyperv_vmbus.h
> > @@ -141,7 +141,7 @@ struct hv_port_info {
> >                 struct {
> >                         u32 target_sint;
> >                         u32 target_vp;
> > -                       u16 base_flag_bumber;
> > +                       u16 base_flag_number;
> 
> Shouldn't it be removed? It is not used anywhere.

Be careful, this might be in a data stream that the kernel driver is
just not using, but the size is needed to properly access other fields.

Only remove it after lots of testing.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux